Skip to content

Fix bad formatting of generated C++ code#39212

Closed
rshest wants to merge 1 commit into
facebook:mainfrom
rshest:export-D48827010
Closed

Fix bad formatting of generated C++ code#39212
rshest wants to merge 1 commit into
facebook:mainfrom
rshest:export-D48827010

Conversation

@rshest
Copy link
Copy Markdown
Contributor

@rshest rshest commented Aug 30, 2023

Summary:

Changelog:

[Internal] -

Some of the generated C++ code was badly formatted - even though it's normally not supposed to be read by humans, sometimes it's still useful/needed, so it helps when it's more readable.

Differential Revision: D48827010

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 30, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48827010

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48827010

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Aug 30, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,962,014 +17
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,555,298 +7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 904d3e8
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48827010

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48827010

Summary:
Pull Request resolved: facebook#39212

## Changelog:
[Internal] -

Some of the generated C++ code was badly formatted - even though it's normally not supposed to be read by humans, sometimes it's still useful/needed, so it helps when it's more readable.

Reviewed By: christophpurrer

Differential Revision: D48827010

fbshipit-source-id: 4347ccda8070e5063c074ca342dbcc5359a16aac
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48827010

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @rshest in 0c292f3.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions Bot added the Merged This PR has been merged. label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants