Remove Flipper actions in Dev Menu, add new Open Debugger action (Android) by huntie · Pull Request #39254 · facebook/react-native

huntie · 2023-09-01T09:42:11Z

Summary:

Context

RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641

Changes

Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu.
Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73.

Changelog:
[Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action

Differential Revision: D46187942

facebook-github-bot · 2023-09-01T09:43:06Z

This pull request was exported from Phabricator. Differential Revision: D46187942

analysis-bot · 2023-09-01T10:12:07Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,341,622	-431
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	9,580,361	-467
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: d208dc4
Branch: main

facebook-github-bot · 2023-09-01T10:20:34Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-01T11:53:48Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-01T11:59:40Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-01T12:05:57Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-01T12:12:42Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-01T13:22:44Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-01T17:07:58Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-03T15:07:36Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-04T15:03:57Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-04T15:57:02Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-14T16:25:58Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-15T08:42:48Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-15T13:10:42Z

This pull request was exported from Phabricator. Differential Revision: D46187942

facebook-github-bot · 2023-09-15T13:35:14Z

This pull request was exported from Phabricator. Differential Revision: D46187942

Differential Revision: D49276125 fbshipit-source-id: 5ae43d865efed61a1bcb1395d1eb2512643b4e06

Differential Revision: https://internalfb.com/D46220076 fbshipit-source-id: 2cc0050febf0ca095190a7103988f6ead92e1e7a

…roid) (facebook#39254) Summary: Pull Request resolved: facebook#39254 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes - Removes Flipper-backed "Launch Debugger" and "Launch React DevTools" actions from the Dev Menu. - Adds replacement "Launch Debugger" action triggering the new one-click Hermes debugger flow for 0.73. Changelog: [Android][Changed] Remove Flipper actions in Dev Menu, add new Open Debugger action #rn-oss-skip-export Reviewed By: cortinico Differential Revision: D46187942 fbshipit-source-id: 17041104eb8edf84eb90c0bed20458f51f2812fe

facebook-github-bot · 2023-09-15T13:42:44Z

This pull request was exported from Phabricator. Differential Revision: D46187942

github-actions · 2023-09-15T14:41:53Z

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against b924fe7edee6ca2e7b08772f13ac82e9fe122868

facebook-github-bot · 2023-09-16T20:52:34Z

This pull request has been merged in 3bc402f.

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 1, 2023

facebook-github-bot added the fb-exported label Sep 1, 2023

huntie force-pushed the export-D46187942 branch from 96923f1 to 80e4558 Compare September 1, 2023 10:20

huntie force-pushed the export-D46187942 branch from 80e4558 to e2949b1 Compare September 1, 2023 11:53

huntie force-pushed the export-D46187942 branch from e2949b1 to 25f8b33 Compare September 1, 2023 11:59

huntie force-pushed the export-D46187942 branch from 25f8b33 to 6c54f7b Compare September 1, 2023 12:06

huntie force-pushed the export-D46187942 branch from 6c54f7b to e277ea1 Compare September 1, 2023 12:12

huntie force-pushed the export-D46187942 branch from e277ea1 to 580aa51 Compare September 1, 2023 13:22

huntie force-pushed the export-D46187942 branch from 580aa51 to aa50da0 Compare September 1, 2023 17:08

huntie force-pushed the export-D46187942 branch from aa50da0 to e275b03 Compare September 3, 2023 15:07

huntie force-pushed the export-D46187942 branch from e275b03 to d73b6ef Compare September 4, 2023 15:03

huntie force-pushed the export-D46187942 branch from d73b6ef to 0857ee2 Compare September 4, 2023 15:57

huntie changed the title ~~Remove Flipper actions in Dev Menu, add new Open Debugger action~~ Remove Flipper actions in Dev Menu, add new Open Debugger action (Android) Sep 14, 2023

huntie force-pushed the export-D46187942 branch from 0857ee2 to e010d62 Compare September 14, 2023 16:26

huntie force-pushed the export-D46187942 branch from e010d62 to a52af00 Compare September 15, 2023 08:43

huntie force-pushed the export-D46187942 branch from a52af00 to 27cb17f Compare September 15, 2023 13:10

huntie force-pushed the export-D46187942 branch from 27cb17f to b924fe7 Compare September 15, 2023 13:35

huntie and others added 3 commits September 15, 2023 06:39

Add serverBaseUrl option, set client-accessible URL value externally

54bcc7c

Differential Revision: D49276125 fbshipit-source-id: 5ae43d865efed61a1bcb1395d1eb2512643b4e06

Remove Flipper actions in Dev Menu, add new Open Debugger action

a090d46

Differential Revision: https://internalfb.com/D46220076 fbshipit-source-id: 2cc0050febf0ca095190a7103988f6ead92e1e7a

huntie force-pushed the export-D46187942 branch from b924fe7 to 1222dfb Compare September 15, 2023 13:42

facebook-github-bot closed this in 3bc402f Sep 16, 2023

facebook-github-bot added the Merged This PR has been merged. label Sep 16, 2023

huntie deleted the export-D46187942 branch February 16, 2024 15:05

Conversation

huntie commented Sep 1, 2023

Context

Changes

Uh oh!

facebook-github-bot commented Sep 1, 2023

Uh oh!

analysis-bot commented Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Sep 1, 2023

Uh oh!

facebook-github-bot commented Sep 1, 2023

Uh oh!

facebook-github-bot commented Sep 1, 2023

Uh oh!

facebook-github-bot commented Sep 1, 2023

Uh oh!

facebook-github-bot commented Sep 1, 2023

Uh oh!

facebook-github-bot commented Sep 1, 2023

Uh oh!

facebook-github-bot commented Sep 1, 2023

Uh oh!

facebook-github-bot commented Sep 3, 2023

Uh oh!

facebook-github-bot commented Sep 4, 2023

Uh oh!

facebook-github-bot commented Sep 4, 2023

Uh oh!

facebook-github-bot commented Sep 14, 2023

Uh oh!

facebook-github-bot commented Sep 15, 2023

Uh oh!

facebook-github-bot commented Sep 15, 2023

Uh oh!

facebook-github-bot commented Sep 15, 2023

Uh oh!

facebook-github-bot commented Sep 15, 2023

Uh oh!

github-actions bot commented Sep 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Sep 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

analysis-bot commented Sep 1, 2023 •

edited

Loading

github-actions bot commented Sep 15, 2023 •

edited

Loading