Skip to content

Fix Transform flip example on new renderer#39259

Closed
javache wants to merge 1 commit into
facebook:mainfrom
javache:export-D48905010
Closed

Fix Transform flip example on new renderer#39259
javache wants to merge 1 commit into
facebook:mainfrom
javache:export-D48905010

Conversation

@javache
Copy link
Copy Markdown
Member

@javache javache commented Sep 1, 2023

Summary:
This matches the behaviour we had in the old renderer where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample.

Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied

Differential Revision: D48905010

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 1, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 1, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Sep 1, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,962,420 -47
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,554,176 -5
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: edff5e9
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 5, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 5, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 5, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 5, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 5, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 5, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 6, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 6, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 6, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@javache @facebook-github-bot
Fix Transform flip example on new renderer (facebook#39259)
f46dd88 
Summary:

This matches the [behaviour we had in the old renderer](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Views/UIView%2BReact.m#L145) where zIndex is mapped to the CALayer's zPosition. This is required to prevent clipping of views in rotation transforms as currently used in the TransformExample.

Changelog: [iOS][Fixed] Rotation transforms are no longer clipped when zIndex is applied

Reviewed By: christophpurrer

Differential Revision: D48905010
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 6, 2023

This pull request was exported from Phabricator. Differential Revision: D48905010

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 6, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against eebe5beeaf1ea6a36d4794e2d8afa9630c2d67a6

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 6, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 6, 2023

This pull request has been merged in 850349b.

@javache javache deleted the export-D48905010 branch September 6, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javache @facebook-github-bot @analysis-bot