Skip to content

Remove folly::F14FastSet from React Native#39490

Closed
sammy-SC wants to merge 1 commit intofacebook:mainfrom
sammy-SC:export-D48967273
Closed

Remove folly::F14FastSet from React Native#39490
sammy-SC wants to merge 1 commit intofacebook:mainfrom
sammy-SC:export-D48967273

Conversation

@sammy-SC
Copy link
Copy Markdown
Contributor

Summary:
changelog: [internal]

Removing use of folly::F14FastSet to reduce the dependency on Folly library.

Reviewed By: rshest

Differential Revision: D48967273

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48967273

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48967273

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48967273

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48967273

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48967273

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Sep 16, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,341,843 -62
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,580,685 -43
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3bc402f
Branch: main

Summary:

changelog: [internal]

Removing use of folly::F14FastSet to reduce the dependency on Folly library.

Reviewed By: rshest

Differential Revision: D48967273
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D48967273

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 17, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in d7d030a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants