Refactor publish-npm args to be more safe#39532
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49374263 |
Base commit: ea85b31 |
kelset
approved these changes
Sep 19, 2023
Summary: This change refactors how we handle the parameters of publish-npm so we can only accept the build types we actually support. ## Changelog: [Internal] - Make publish-npm args stricter Reviewed By: cortinico Differential Revision: D49374263
cipolleschi
force-pushed
the
export-D49374263
branch
from
d73bc0f to
5eda782
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49374263 |
cipolleschi
force-pushed
the
export-D49374263
branch
from
5eda782 to
9a3b222
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49374263 |
Contributor
|
This pull request has been merged in 780567c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change refactors how we handle the parameters of publish-npm so we can only accept the build types we actually support.
Changelog:
[Internal] - Make publish-npm args stricter
Differential Revision: D49374263