Skip to content

Fix typo of JSI module Cpp codegen#39604

Closed
Sunbreak wants to merge 1 commit into
facebook:mainfrom
Sunbreak:jsi-codegen-typo
Closed

Fix typo of JSI module Cpp codegen#39604
Sunbreak wants to merge 1 commit into
facebook:mainfrom
Sunbreak:jsi-codegen-typo

Conversation

@Sunbreak
Copy link
Copy Markdown
Contributor

Summary:

Fix code generatetion comment from GenerateModuleH.js to GenerateModuleCpp.js

Changelog:

[GENERAL] [FIXED] - Fix typo of JSI module Cpp codegen

Test Plan:

None

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 22, 2023
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,337,086 +22
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,575,354 -5
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8c5340f
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 25, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in af7bf93.

@Sunbreak Sunbreak deleted the jsi-codegen-typo branch September 26, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants