[iOS] Don't load RCTRootViewIntegrationTestsApp.bundle in objc-test.sh#39615
Closed
Saadnajmi wants to merge 1 commit into
Closed
[iOS] Don't load RCTRootViewIntegrationTestsApp.bundle in objc-test.sh#39615Saadnajmi wants to merge 1 commit into
Saadnajmi wants to merge 1 commit into
Conversation
https://github.com/facebook/react-native/pull/38871/files#diff-2e097a9d306fd2c17dd09a4cc94830f04b1a8c7ca5cb4cf4881dbc534026a4fa removed all the RCTRootViewIntegrationTest stuff. Looks like we missed a line so I'm removing now.
facebook-github-bot
added
CLA Signed
Saadnajmi
changed the title
facebook-github-bot
added
the
Shared with Meta
Base commit: 0f2ecd3 |
Contributor
|
@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @Saadnajmi in 036d507. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#38871 removed all the RCTRootViewIntegrationTest stuff. Looks like we missed a line so I'm removing now.
Changelog:
[INTERNAL] [FIXED] - Don't load RCTRootViewIntegrationTestsApp.bundle in objc-test.sh
Test Plan:
CI should pass