Disable max WebSocket message size validation in CDP proxy#39809
Closed
motiz88 wants to merge 1 commit into
Closed
Disable max WebSocket message size validation in CDP proxy#39809motiz88 wants to merge 1 commit into
motiz88 wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49642047 |
motiz88
force-pushed
the
export-D49642047
branch
from
1401f24 to
3fa87c8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49642047 |
…39809) Summary: It's currently possible for RN to crash the dev server by sending down an exceptionally large CDP response/event. Instead of making assumptions on the protocol spoken over the proxy, let's assume clients on either side of the proxy can be trusted to be well behaved (and to degrade gracefully when a large message is encountered). Changelog: [General][Fixed] JS debugging: prevent dev server crash when a large CDP payload is returned from the device Reviewed By: huntie Differential Revision: D49642047
motiz88
force-pushed
the
export-D49642047
branch
from
3fa87c8 to
7070b84
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49642047 |
Contributor
|
This pull request has been merged in 2000acc. |
Contributor
|
This pull request has been reverted by 7d88ac4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
It's currently possible for RN to crash the dev server by sending down an exceptionally large CDP response/event. Instead of making assumptions on the protocol spoken over the proxy, let's assume clients on either side of the proxy can be trusted to be well behaved (and to degrade gracefully when a large message is encountered).
Changelog: [General][Fixed] JS debugging: prevent dev server crash when a large CDP payload is returned from the device
Reviewed By: huntie
Differential Revision: D49642047