Skip to content

Drop RCT prefix from RCTRequired folder #39955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabriziocucci wants to merge 1 commit into from
Closed

Drop RCT prefix from RCTRequired folder #39955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ package-lock.json

# Libs that shouldn't have Xcode project
/packages/react-native/Libraries/FBLazyVector/**/*.xcodeproj
/packages/react-native/Libraries/RCTRequired/**/*.xcodeproj
/packages/react-native/Libraries/Required/**/*.xcodeproj
/packages/react-native/React/CoreModules/**/*.xcodeproj
/packages/react-native/React/FBReactNativeSpec/**/*.xcodeproj
/packages/react-native-codegen/**/*.xcodeproj
Expand Down
0 ...ies/RCTRequired/RCTRequired/RCTRequired.h → ...t-native/Libraries/Required/RCTRequired.h
View file
Open in desktop
File renamed without changes.
0 ...Libraries/RCTRequired/RCTRequired.podspec → ...ve/Libraries/Required/RCTRequired.podspec
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/react-native/scripts/react_native_pods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def use_react_native! (
# The Pods which should be included in all projects
pod 'FBLazyVector', :path => "#{prefix}/Libraries/FBLazyVector"
pod 'FBReactNativeSpec', :path => "#{prefix}/React/FBReactNativeSpec" if !NewArchitectureHelper.new_arch_enabled
pod 'RCTRequired', :path => "#{prefix}/Libraries/RCTRequired"
pod 'RCTRequired', :path => "#{prefix}/Libraries/Required"
pod 'RCTTypeSafety', :path => "#{prefix}/Libraries/TypeSafety", :modular_headers => true
pod 'React', :path => "#{prefix}/"
pod 'React-Core', :path => "#{prefix}/"
Expand Down
4 changes: 2 additions & 2 deletions packages/rn-tester/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,7 +1170,7 @@ DEPENDENCIES:
- OpenSSL-Universal (= 1.1.1100)
- RCT-Folly (from `../react-native/third-party-podspecs/RCT-Folly.podspec`)
- RCT-Folly/Fabric (from `../react-native/third-party-podspecs/RCT-Folly.podspec`)
- RCTRequired (from `../react-native/Libraries/RCTRequired`)
- RCTRequired (from `../react-native/Libraries/Required`)
- RCTTypeSafety (from `../react-native/Libraries/TypeSafety`)
- React (from `../react-native/`)
- React-callinvoker (from `../react-native/ReactCommon/callinvoker`)
Expand Down Expand Up @@ -1253,7 +1253,7 @@ EXTERNAL SOURCES:
RCT-Folly:
:podspec: "../react-native/third-party-podspecs/RCT-Folly.podspec"
RCTRequired:
:path: "../react-native/Libraries/RCTRequired"
:path: "../react-native/Libraries/Required"
RCTTypeSafety:
:path: "../react-native/Libraries/TypeSafety"
React:
Expand Down