fix(jest): added sdks dir to testPathIgnorePatterns to prevent hermes specific tests to run#40734
Closed
ecreeth wants to merge 1 commit into
Closed
fix(jest): added sdks dir to testPathIgnorePatterns to prevent hermes specific tests to run#40734ecreeth wants to merge 1 commit into
sdks dir to testPathIgnorePatterns to prevent hermes specific tests to run#40734ecreeth wants to merge 1 commit into
Conversation
…ermes` specific tests to run
facebook-github-bot
added
CLA Signed
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
robhogan
approved these changes
Oct 9, 2023
Contributor
robhogan
left a comment
robhogan
left a comment
There was a problem hiding this comment.
Thanks! Just going to change the changelog to Internal, because this doesn't affect RN users.
|
This pull request was successfully merged by @ecreeth in ea88fbe. When will my fix make it into a release? | Upcoming Releases |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When we download the
hermesrepo, we also include its tests, sojesttry to run them.Changelog:
[INTERNAL][FIXED]: don't run
hermesspecific tests.Test Plan:
sdksdirectory.