Align directory name for normalize-colors#40934
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50229030 |
huntie
force-pushed
the
export-D50229030
branch
from
6d00807 to
048b1b8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50229030 |
Base commit: 2d8797a |
huntie
force-pushed
the
export-D50229030
branch
from
048b1b8 to
d7f6817
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50229030 |
Summary: The previous `packages/normalize-color` directory name could be confusing, given we have previously published a `react-native/normalize-color` package in addition to the current `react-native/normalize-colors`. After this change, the directory name and `package.json` `"name"` field are aligned. Changelog: [Internal] Reviewed By: cortinico, NickGerleman Differential Revision: D50229030
huntie
force-pushed
the
export-D50229030
branch
from
d7f6817 to
4813c9e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50229030 |
huntie
force-pushed
the
export-D50229030
branch
from
4813c9e to
cc36ba3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50229030 |
Generated by 🚫 dangerJS against d7f6817399426923591b51fe3baeb1684fbf092e |
Contributor
|
This pull request has been merged in c5abe1e. |
Contributor
|
This pull request has been reverted by b21cf6f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The previous
packages/normalize-colordirectory name could be confusing, given we have previously published areact-native/normalize-colorpackage in addition to the currentreact-native/normalize-colors. After this change, the directory name andpackage.json"name"field are aligned.Changelog: [Internal]
Reviewed By: cortinico, NickGerleman
Differential Revision: D50229030