Skip to content

Remove RNTester Bookmarks#41016

Closed
NickGerleman wants to merge 1 commit into
facebook:mainfrom
NickGerleman:export-D50297980
Closed

Remove RNTester Bookmarks#41016
NickGerleman wants to merge 1 commit into
facebook:mainfrom
NickGerleman:export-D50297980

Conversation

@NickGerleman
Copy link
Copy Markdown
Contributor

Summary:
This hasn't been very useful since AsyncStorage/persistence was removed, but takes up a good amount of usable screen real-estate for information in the center of the screen. Remove it.

Changelog: [Internal]

Differential Revision: D50297980

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 16, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50297980

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 16, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,618,995 -5,580
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,992,559 -4,648
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fbc28fa
Branch: main

Summary:
Pull Request resolved: facebook#41016

This hasn't been very useful since AsyncStorage/persistence was removed, but takes up a good amount of usable screen real-estate for information in the center of the screen. Remove it.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D50297980

fbshipit-source-id: 9d688ca2524628c666d8885ade39cc5322c52b97
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50297980

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 17, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 26b4145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants