Reduce visibility of CoreModulesPackage#41087
Closed
mdvacca wants to merge 4 commits intofacebook:mainfrom
Closed
Conversation
Summary: DebugCorePackage is only used from com.facebook.react, there are no interesting usages internally at Meta or in OSS, so I'm reducing the visibility to package. bypass-github-export-checks changelog: [Android][Breaking] Reducing visibility of DebugCorePackage Reviewed By: christophpurrer Differential Revision: D50338294
Summary: Deprecate CompositeReactPackageTurboModuleManagerDelegate bypass-github-export-checks changelog: [Android][Changed] Deprecate CompositeReactPackageTurboModuleManagerDelegate Reviewed By: RSNara Differential Revision: D50338303
Summary: This was probably caused by a copy paste, I'm fixing the log message to describe the proper class. bypass-github-export-checks changelog: [internal] internal Reviewed By: RSNara Differential Revision: D50338296
Summary: CoreModulesPackage is not being used outside of its package (neither in OSS or at Meta), I'm reducing its visibiity to package. If you are using this class, please contact us and we will consider increasing visibiity again. bypass-github-export-checks changelog: [Android][Breaking] Reduce visibility of CoreModulesPackage class Reviewed By: christophpurrer Differential Revision: D50338546
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50338546 |
Base commit: c068071 |
Contributor
|
This pull request has been merged in 30b9b01. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
CoreModulesPackage is not being used outside of its package (neither in OSS or at Meta), I'm reducing its visibiity to package.
If you are using this class, please contact us and we will consider increasing visibiity again.
bypass-github-export-checks
changelog: [Android][Breaking] Reduce visibility of CoreModulesPackage class
Reviewed By: christophpurrer
Differential Revision: D50338546