Revert ReactInstanceManager this::invokeDefaultOnBackPressed lambda#41132
Closed
janeli-100005636499545 wants to merge 1 commit into
Closed
Revert ReactInstanceManager this::invokeDefaultOnBackPressed lambda#41132janeli-100005636499545 wants to merge 1 commit into
janeli-100005636499545 wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50520227 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50520227 |
janeli-100005636499545
force-pushed
the
export-D50520227
branch
from
d1ca2a1 to
3df0dda
Compare
…acebook#41132) Summary: changelog: [internal] internal Reviewed By: fkgozali, mdvacca Differential Revision: D50520227
janeli-100005636499545
force-pushed
the
export-D50520227
branch
from
3df0dda to
48568de
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50520227 |
Base commit: 28d7ade |
|
This pull request was successfully merged by @janeli-100005636499545 in e651a56. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We got reports of the Twilight Android app crashing whenever the user presses the OS back button. Crash logs here: P860542895
Upon investigating, this issue happens only on the twilight_release build, not the twilight_debug or twilight-android build. Thus, we believe the issue is related to Proguard's optimization of the app since twilight_release is the only build of the app that gets the full Proguard optimization.
Changing ReactInstanceManager's function from lambda back to its original (it was converted to a lambda here: D45062457) fixes this issue, likely because Proguard was having trouble optimizing it correctly.
It's not 100% clear to me why this issue appeared on v238 as the mobile bisect shows this issue started beteween Oct 12 7:28AM and 8:22AM but D45062457 was landed in April. One hypothesis I have is that Proguard had a version update on Oct 12 which may have contributed.
changelog: [internal] internal
Differential Revision: D50520227