Fix AppDelegate not passing props in bridgeless and rename getBundleURL#41169
Closed
javache wants to merge 1 commit into
Closed
Fix AppDelegate not passing props in bridgeless and rename getBundleURL#41169javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50595790 |
…RL (facebook#41169) Summary: * `initialProperties` should be based on `prepareInitialProps`, not `launchOptions` (which don't seem to have an equivalent in bridgeless) * `getBundleURL` is not idiomatic Objective-C (eg https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html), so rename to `bundleURL` Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D50595790
javache
force-pushed
the
export-D50595790
branch
from
8a57559 to
76ba5ae
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50595790 |
Base commit: 70acd3f |
Contributor
|
This pull request has been merged in 31cf4c4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
initialPropertiesshould be based onprepareInitialProps, notlaunchOptions(which don't seem to have an equivalent in bridgeless)getBundleURLis not idiomatic Objective-C (eg https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html), so rename tobundleURLChangelog: [Internal]
Differential Revision: D50595790