Skip to content

setup test to use custom queue for RCTBlobManager operations instead of module queue#41182

Closed
philIip wants to merge 1 commit into
facebook:mainfrom
philIip:export-D50587693
Closed

setup test to use custom queue for RCTBlobManager operations instead of module queue#41182
philIip wants to merge 1 commit into
facebook:mainfrom
philIip:export-D50587693

Conversation

@philIip
Copy link
Copy Markdown
Contributor

@philIip philIip commented Oct 25, 2023

Summary:
Changelog: [Internal]

in my quest to get rid of all synthesized methodQueues, we have RCTBlobManager which exposes its underlying execution queue. in this diff, i add a config that replaces that queue with one that is managed by the module itself instead of the one generated by the infra.

Reviewed By: cipolleschi

Differential Revision: D50587693

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50587693

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 25, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,649,163 +6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,030,920 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 7e26e02
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50587693

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50587693

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50587693

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50587693

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50587693

…of module queue (facebook#41182)

Summary:

Changelog: [Internal]

in my quest to get rid of all synthesized methodQueues, we have RCTBlobManager which exposes its underlying execution queue. in this diff, i add a config that replaces that queue with one that is managed by the module itself instead of the one generated by the infra.

Reviewed By: cipolleschi

Differential Revision: D50587693
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D50587693

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 25, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 7093a45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants