fix: dark mode in SnapshotExample in RNTester#41222
Closed
krozniata wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
Are there any blockers to merge this? |
| Click to take a screenshot | ||
| </Text> | ||
| <Image | ||
| style={[style.image, {backgroundColor: theme.LabelColor}]} |
Contributor
There was a problem hiding this comment.
Why does image background get color for text?
Contributor
Author
There was a problem hiding this comment.
I used LabelColor as it's currently only theme color that's opposite to background color
Contributor
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@NickGerleman merged this pull request in 371af3f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes issue in
RNTestercausing labels and image background to not be visible in dark mode inSnapshotExampleIt also fixes issue with description in
Headernot being visible in other components examples when using dark modeBefore & After
Changelog:
[INTERNAL] [FIXED] - Fix dark mode in SnapshotExample in RNTester
Test Plan:
RNTesterwith dark mode enabledSnapshot / Screenshotexample