Clean up eventTarget retaining logic in the pointer event processor#41471
Closed
vincentriemer wants to merge 1 commit into
Closed
Clean up eventTarget retaining logic in the pointer event processor#41471vincentriemer wants to merge 1 commit into
vincentriemer wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51279974 |
Base commit: ca9b6b5 |
vincentriemer
force-pushed
the
export-D51279974
branch
from
f9dcfd4 to
95a9b71
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51279974 |
vincentriemer
force-pushed
the
export-D51279974
branch
from
95a9b71 to
291856d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51279974 |
vincentriemer
added a commit
to vincentriemer/react-native
that referenced
this pull request
Nov 16, 2023
…acebook#41471) Summary: Changelog: [Internal] - Clean up eventTarget retaining logic in the pointer event processor This refactors calls to EventTarget::retain/release to occur in the actual methods that require the event target to be retained instead of expecting the caller to manage that which should be more maintainable. Differential Revision: D51279974
vincentriemer
force-pushed
the
export-D51279974
branch
from
291856d to
81480cf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51279974 |
vincentriemer
force-pushed
the
export-D51279974
branch
from
81480cf to
36be802
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51279974 |
…acebook#41471) Summary: Changelog: [Internal] - Clean up eventTarget retaining logic in the pointer event processor This refactors calls to EventTarget::retain/release to occur in the actual methods that require the event target to be retained instead of expecting the caller to manage that which should be more maintainable. Reviewed By: sammy-SC Differential Revision: D51279974
vincentriemer
force-pushed
the
export-D51279974
branch
from
36be802 to
2bc5229
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51279974 |
vincentriemer
force-pushed
the
export-D51279974
branch
from
2bc5229 to
a02cda0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51279974 |
|
This pull request was successfully merged by @vincentriemer in 952b32b. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal] - Clean up eventTarget retaining logic in the pointer event processor
This refactors calls to EventTarget::retain/release to occur in the actual methods that require the event target to be retained instead of expecting the caller to manage that which should be more maintainable.
Differential Revision: D51279974