Remove dependency on libevent#41486
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51307333 |
Base commit: 560e0f0 |
Summary: Now that React-Hermes does not depends on folly::Futures anymore, we can safely delete the `libevent` dependency. This will speedup the pod install step and potentially also the bundle size (to be tested) ## Changelog [iOS][Removed] - Remove libevent dependency Reviewed By: javache Differential Revision: D51307333
cipolleschi
force-pushed
the
export-D51307333
branch
from
da7a89e to
7e642b2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51307333 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 15, 2023
Summary: Now that React-Hermes does not depends on folly::Futures anymore, we can safely delete the `libevent` dependency. This will speedup the pod install step and potentially also the bundle size (to be tested) ## Changelog [iOS][Removed] - Remove libevent dependency Reviewed By: javache Differential Revision: D51307333
Contributor
|
This pull request has been merged in 23cf104. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Now that React-Hermes does not depends on folly::Futures anymore, we can safely delete the
libeventdependency.This will speedup the pod install step and potentially also the bundle size (to be tested)
Changelog
[iOS][Removed] - Remove libevent dependency
Differential Revision: D51307333