Add InspectorFlags, conditionally disable Hermes CDP registration#41672
Add InspectorFlags, conditionally disable Hermes CDP registration#41672huntie wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
Base commit: 8832dda |
huntie
force-pushed
the
export-D51563107
branch
from
4b7bd20 to
7b7c9fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
7b7c9fa to
26d9191
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
26d9191 to
a75eb3c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
a75eb3c to
f88857f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
f88857f to
e886a47
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
e886a47 to
72398b3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
72398b3 to
11667bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
11667bc to
137bea0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
137bea0 to
ac627d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
ac627d5 to
e0defe1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
e0defe1 to
42a25b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
42a25b2 to
5ae2b7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
huntie
force-pushed
the
export-D51563107
branch
from
5ae2b7a to
76eb358
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
…cebook#41672) Summary: Progress towards an opt-in setup for our new CDP backend. - Adds `InspectorFlags.h`, a singleton intended to allow convienient access to static boolean feature flags for the new CDP backend/inspector features across platforms. This will be written to in upcoming diffs, with the accessor for `enable_modern_cdp_registry` soft-defaulting to `false` here. - References this to conditionally disable legacy ~CDP registration in `HermesExecutorFactory` (Bridge) and `HermesInstance` (Bridgeless) code paths. - Stubs a `false` value for `react_native_devx:enable_modern_cdp_registry` in `EmptyReactNativeConfig` (documentation/convenience point for open source partners and integrators). Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D51563107
huntie
force-pushed
the
export-D51563107
branch
from
76eb358 to
84d1c0b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51563107 |
|
This pull request was successfully merged by @huntie in b6adbf7. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in b6adbf7. |
3 participants
Summary:
Progress towards an opt-in setup for our new CDP backend.
InspectorFlags.h, a singleton intended to allow convienient access to static boolean feature flags for the new CDP backend/inspector features across platforms. This will be written to in upcoming diffs, with the accessor forenable_modern_cdp_registrysoft-defaulting tofalsehere.HermesExecutorFactory(Bridge) andHermesInstance(Bridgeless) code paths.falsevalue forreact_native_devx:enable_modern_cdp_registryinEmptyReactNativeConfig(documentation/convenience point for open source partners and integrators).Changelog: [Internal]
Differential Revision: D51563107