Skip to content

Add GraphNode example for Cxx TMs#41766

Closed
christophpurrer wants to merge 1 commit into
facebook:mainfrom
christophpurrer:export-D51783974
Closed

Add GraphNode example for Cxx TMs#41766
christophpurrer wants to merge 1 commit into
facebook:mainfrom
christophpurrer:export-D51783974

Conversation

@christophpurrer
Copy link
Copy Markdown
Contributor

Summary:
Changelog: [Internal]

Adds a simple example showing a recursive node inside a collection in a Cxx TM.

Currently we can't auto-generate the necessary C++ Types - but we can add it later if this scenarios becomes really common.

Differential Revision: D51783974

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51783974

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Dec 2, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,721,825 +16,360
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,109,060 +16,447
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3854735
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51783974

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51783974

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51783974

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 3, 2023
Summary:

Changelog: [Internal]

Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM.

Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common.

Differential Revision: D51783974
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51783974

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51783974

Summary:

Changelog: [Internal]

Adds a simple example showing a recursive node, stored inside a collection in a Cxx TM.

Currently we can't auto-generate [the necessary C++ Types](https://reactnative.dev/docs/next/the-new-architecture/cxx-custom-types#struct-generator) - but we can add it later if this scenarios becomes really common.

Reviewed By: rshest

Differential Revision: D51783974
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D51783974

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 4, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2023

This pull request was successfully merged by @christophpurrer in 5754b4a.

When will my fix make it into a release? | Upcoming Releases

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 5754b4a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants