Remove legacy tests inside packages/react-native/ReactAndroid/src/androidTest/#41802
Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
Closed
Remove legacy tests inside packages/react-native/ReactAndroid/src/androidTest/#41802cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51805702 |
Base commit: 31005b7 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51805702 |
cortinico
force-pushed
the
export-D51805702
branch
from
ed2dc73 to
cab2602
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51805702 |
cortinico
force-pushed
the
export-D51805702
branch
from
cab2602 to
0437798
Compare
…roidTest/ (facebook#41802) Summary: Pull Request resolved: facebook#41802 Those tests are not executing at all, they're just compiled. We do have different tests that cover those scenarios so it's not worth to keep this infrastructure around. Changelog: [Internal] [Changed] - Remove legacy tests inside packages/react-native/ReactAndroid/src/androidTest/ Reviewed By: rshest Differential Revision: D51805702 fbshipit-source-id: cfe1e2d08bfe6abdb939603693aaf0dc9d737878
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51805702 |
cortinico
force-pushed
the
export-D51805702
branch
from
0437798 to
b6741cf
Compare
Contributor
|
This pull request has been merged in d992abc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Those tests are not executing at all, they're just compiled.
We do have different tests that cover those scenarios so it's not worth to keep this infrastructure around.
Changelog:
[Internal] [Changed] - Remove legacy tests inside packages/react-native/ReactAndroid/src/androidTest/
Differential Revision: D51805702