Skip to content

Lint source files, sort imports, remove unused imports#41829

Closed
okwasniewski wants to merge 1 commit into
facebook:mainfrom
okwasniewski:fix/eslint
Closed

Lint source files, sort imports, remove unused imports#41829
okwasniewski wants to merge 1 commit into
facebook:mainfrom
okwasniewski:fix/eslint

Conversation

@okwasniewski
Copy link
Copy Markdown
Contributor

@okwasniewski okwasniewski commented Dec 7, 2023

Summary:

This PR lints source files using eslint. I've executed yarn lint --fix and also manually fixed some of eslint issues.

Before:

CleanShot 2023-12-07 at 12 07 10@2x

After:

CleanShot 2023-12-07 at 12 06 24@2x

Changelog:

[GENERAL] [FIXED] - Lint source files, sort imports, remove unused ones

Test Plan:

CI Green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Dec 7, 2023
@okwasniewski okwasniewski changed the title Lint source files, sort imports, remove unused ones Lint source files, sort imports, remove unused imports Dec 7, 2023
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Dec 7, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,513,627 -28
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,884,261 +16
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 186fc85
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 11, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@dmytrorykun merged this pull request in 7d1a98c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants