Resolve several Gradle build warning#41831
Closed
cortinico wants to merge 4 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890225 |
cortinico
force-pushed
the
export-D51890225
branch
from
fa52f5d to
910e06f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890225 |
cortinico
force-pushed
the
export-D51890225
branch
from
910e06f to
30b321f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890225 |
cortinico
force-pushed
the
export-D51890225
branch
from
30b321f to
968cba0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890225 |
Base commit: 3ed4bf9 |
cortinico
force-pushed
the
export-D51890225
branch
from
968cba0 to
7e2e090
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890225 |
cortinico
force-pushed
the
export-D51890225
branch
from
7e2e090 to
0dc55e6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890225 |
Summary: I'm updating other two `build.gradle` to `build.gradle.kts` files. The only functional change I made was to remove the function to check if major >= 1 and turn on New Architecture. This needs to be moved to RNGP as Kotlin doesn't have dynamic accessors to Object so we can't convert that function. Changelog: [Internal] [Changed] - Convert ReactAndroid and RN-Tester to Kotlin DSL Reviewed By: mdvacca Differential Revision: D51856356
Summary: I'm removing those environment variables as they're legacy and not used anymore: - REACT_NATIVE_SKIP_PREFAB - REACT_NATIVE_HERMES_SKIP_PREFAB Changelog: [Internal] [Changed] - Remove REACT_NATIVE_SKIP_PREFAB as unused Reviewed By: dmytrorykun Differential Revision: D51890227
Summary: I'm removing the `installArchives` task and all the setup to publish the Maven Local inside the NPM package as we're not using this entirely and we won't be able to use it anyway (as the Maven Local is too big to fit an NPM package). Changelog: [Internal] [Changed] - Remove the installArchives task Reviewed By: GijsWeterings Differential Revision: D51890224
Summary: The build is currently firing several build warnings due to the Groovy -> Kotlin migration. I've fixed them all over here. Changelog: [Internal] [Changed] - Resolve several Gradle build warning Reviewed By: mdvacca Differential Revision: D51890225
cortinico
force-pushed
the
export-D51890225
branch
from
0dc55e6 to
96afb45
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51890225 |
Contributor
|
This pull request has been merged in 2bf29a3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The build is currently firing several build warnings due to the Groovy -> Kotlin migration.
I've fixed them all over here.
Changelog:
[Internal] [Changed] - Resolve several Gradle build warning
Differential Revision: D51890225