Skip to content

Use enum classes in C++ Turbo Modules#41923

Closed
christophpurrer wants to merge 1 commit into
facebook:mainfrom
christophpurrer:export-D52098598
Closed

Use enum classes in C++ Turbo Modules#41923
christophpurrer wants to merge 1 commit into
facebook:mainfrom
christophpurrer:export-D52098598

Conversation

@christophpurrer
Copy link
Copy Markdown
Contributor

@christophpurrer christophpurrer commented Dec 13, 2023

Summary: Changelog: [Internal]

Differential Revision: D52098598

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 13, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Dec 13, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,524,789 -4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,899,549 -7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 1e22fa3
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 13, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 13, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 13, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 13, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 13, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 13, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 13, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 13, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@christophpurrer @facebook-github-bot
Use enum classes in C++ Turbo Modules (facebook#41923)
b03e014 
Summary:

Changelog: [Internal][BREAKING] Use C++ enum classes in C++ Turbo Modules

Problem:
Using **C styles** `enums` can easily cause compiliation errors if symbol names collide. This code does not compile:
```
enum CustomEnumInt { A = 23, B = 42 };

static int A = 22;
```

This **C++ code**, using `enum classes` compiles:
```
enum class CustomEnumInt : int32_t { A = 23, B = 42 };

static int A = 22;
```

Reviewed By: rshest

Differential Revision: D52098598
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 14, 2023

This pull request was exported from Phabricator. Differential Revision: D52098598

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 14, 2023

This pull request was successfully merged by @christophpurrer in 8183afe.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions Bot added the Merged This PR has been merged. label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christophpurrer @facebook-github-bot @analysis-bot