Improved RNTester deeplink support to go straight to a specific example#41981
Closed
fkgozali wants to merge 1 commit into
Closed
Improved RNTester deeplink support to go straight to a specific example#41981fkgozali wants to merge 1 commit into
fkgozali wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52227013 |
fkgozali
force-pushed
the
export-D52227013
branch
from
00b2ba8 to
d4a840e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52227013 |
fkgozali
force-pushed
the
export-D52227013
branch
from
d4a840e to
ece422b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52227013 |
fkgozali
force-pushed
the
export-D52227013
branch
from
ece422b to
4e04e57
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52227013 |
fkgozali
force-pushed
the
export-D52227013
branch
from
4e04e57 to
3bf35fd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52227013 |
…le (facebook#41981) Summary: Improved RNTester URL deeplink support to cover: * `rntester://example/<moduleKey>` * `rntester://example/<moduleKey>/<exampleKey>` Extra details: * For example modules that do not specify `showIndividualExamples: true`, allow deeplink URL with the specific exampleKey to only render the specific example, instead of all of them. * Added flexibility for moduleKey: search for optional suffixes ("Index", "Example"). * Adjusted Back button action to properly go back to the root after a deeplink. * Added `example-container` generic testID on the example wrapper component. Changelog: [Internal] Reviewed By: yungsters, NickGerleman Differential Revision: D52227013
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Dec 21, 2023
…le (facebook#41981) Summary: Improved RNTester URL deeplink support to cover: * `rntester://example/<moduleKey>` * `rntester://example/<moduleKey>/<exampleKey>` Extra details: * For example modules that do not specify `showIndividualExamples: true`, allow deeplink URL with the specific exampleKey to only render the specific example, instead of all of them. * Added flexibility for moduleKey: search for optional suffixes ("Index", "Example"). * Adjusted Back button action to properly go back to the root after a deeplink. * Added `example-container` generic testID on the example wrapper component. Changelog: [Internal] Reviewed By: yungsters, NickGerleman Differential Revision: D52227013
fkgozali
force-pushed
the
export-D52227013
branch
from
3bf35fd to
f344bb3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52227013 |
|
This pull request was successfully merged by @fkgozali in a47d7c5. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Improved RNTester URL deeplink support to cover:
rntester://example/<moduleKey>rntester://example/<moduleKey>/<exampleKey>Extra details:
showIndividualExamples: true, allow deeplink URL with the specific exampleKey to only render the specific example, instead of all of them.example-containergeneric testID on the example wrapper component.Changelog: [Internal]
Differential Revision: D52227013