BridgelessUIManager: Align platform-only methods w/ PaperUIManager#41997
Closed
RSNara wants to merge 1 commit into
Closed
BridgelessUIManager: Align platform-only methods w/ PaperUIManager#41997RSNara wants to merge 1 commit into
RSNara wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
a32a7b5 to
65e641a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
65e641a to
0c51194
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
2 times, most recently
from
b77c800 to
6c2b506
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
6c2b506 to
85143e9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
85143e9 to
cee7ed3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
cee7ed3 to
d608f51
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
d608f51 to
17ef3f0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
force-pushed
the
export-D52012876
branch
from
17ef3f0 to
152c0c2
Compare
RSNara
force-pushed
the
export-D52012876
branch
from
bd2a0c6 to
c85265e
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41997) Summary: Pull Request resolved: facebook#41997 Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876 fbshipit-source-id: c813be1240331f53d3568dc2e30e0e22798c5320
…acebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
RSNara
force-pushed
the
export-D52012876
branch
from
c85265e to
6dfdd6b
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52012876 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 10, 2024
…Manager (facebook#41997) Summary: Many methods on PaperUIMangaer are iOS only. Many methods on PaperUIManager are Android only. This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52012876
|
This pull request was successfully merged by @RSNara in 4ed4ea1. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Many methods on PaperUIMangaer are iOS only.
Many methods on PaperUIManager are Android only.
This diff makes sure that BridgelessUIManager only exports Android methods on Android, and iOS methods on iOS.
Changelog: [Internal]
Differential Revision: D52012876