use Pressable over TouchableWithoutFeedback#42016
Closed
sammy-SC wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52328529 |
sammy-SC
force-pushed
the
export-D52328529
branch
from
a01209e to
8ba6205
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52328529 |
sammy-SC
force-pushed
the
export-D52328529
branch
from
8ba6205 to
7c50814
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52328529 |
sammy-SC
force-pushed
the
export-D52328529
branch
from
7c50814 to
6581daf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52328529 |
sammy-SC
force-pushed
the
export-D52328529
branch
from
6581daf to
a5103d4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52328529 |
Summary: changelog: [internal] TouchableWithoutFeedback is broken with React 18. Before we fix it, let's use Pressable in tests. Reviewed By: fkgozali Differential Revision: D52328529
sammy-SC
force-pushed
the
export-D52328529
branch
from
a5103d4 to
de9e02e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52328529 |
|
This pull request was successfully merged by @sammy-SC in 4885743. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
TouchableWithoutFeedback is broken with React 18. Before we fix it, let's use Pressable in tests.
Differential Revision: D52328529