Skip to content

Rename prefix of binaryCompatibilityValidator properties #42041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 1 commit into from
Closed

Rename prefix of binaryCompatibilityValidator properties #42041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,13 @@ fun getListReactAndroidProperty(name: String) = reactAndroidProperties.getProper

apiValidation {
ignoredPackages.addAll(
getListReactAndroidProperty("react.internal.binaryCompatibilityValidator.ignoredPackages"))
ignoredClasses.addAll(
getListReactAndroidProperty("react.internal.binaryCompatibilityValidator.ignoredClasses"))
getListReactAndroidProperty("binaryCompatibilityValidator.ignoredPackages"))
ignoredClasses.addAll(getListReactAndroidProperty("binaryCompatibilityValidator.ignoredClasses"))
nonPublicMarkers.addAll(
getListReactAndroidProperty("react.internal.binaryCompatibilityValidator.nonPublicMarkers"))
getListReactAndroidProperty("binaryCompatibilityValidator.nonPublicMarkers"))
validationDisabled =
reactAndroidProperties
.getProperty("react.internal.binaryCompatibilityValidator.validationDisabled")
.getProperty("binaryCompatibilityValidator.validationDisabled")
?.toBoolean() == true
}

Expand Down
10 changes: 5 additions & 5 deletions packages/react-native/ReactAndroid/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ android.enableJetifier=true
react.internal.disableJavaVersionAlignment=true

# Binary Compatibility Validator properties
react.internal.binaryCompatibilityValidator.ignoredClasses=com.facebook.react.BuildConfig
react.internal.binaryCompatibilityValidator.ignoredPackages=com.facebook.debug,\
binaryCompatibilityValidator.ignoredClasses=com.facebook.react.BuildConfig
binaryCompatibilityValidator.ignoredPackages=com.facebook.debug,\
com.facebook.fbreact,\
com.facebook.hermes,\
com.facebook.perftest,\
Expand All @@ -22,7 +22,7 @@ react.internal.binaryCompatibilityValidator.ignoredPackages=com.facebook.debug,\
com.facebook.react.processing,\
com.facebook.systrace,\
com.facebook.yoga
react.internal.binaryCompatibilityValidator.nonPublicMarkers=com.facebook.react.common.annotations.VisibleForTesting,\
binaryCompatibilityValidator.nonPublicMarkers=com.facebook.react.common.annotations.VisibleForTesting,\
com.facebook.react.common.annotations.UnstableReactNativeAPI
react.internal.binaryCompatibilityValidator.validationDisabled=true
react.internal.binaryCompatibilityValidator.outputApiFileName=ReactAndroid
binaryCompatibilityValidator.validationDisabled=true
binaryCompatibilityValidator.outputApiFileName=ReactAndroid