Refactor ScrollView example to trigger onScrollToTop#42127
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52509669 |
cipolleschi
force-pushed
the
export-D52509669
branch
from
7ca7189 to
fd3fa6b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52509669 |
cipolleschi
force-pushed
the
export-D52509669
branch
from
fd3fa6b to
fe743a7
Compare
Summary: The current scrollViewExamples does not trigger the OnScrollToTop event. This change for Paper adds that and refactors the codebase to isolate that example. ## Changelog: [Internal] - Improve RNTester ScrollView example adding OnScrollView event. Reviewed By: sammy-SC Differential Revision: D52509669
cipolleschi
force-pushed
the
export-D52509669
branch
from
fe743a7 to
95e2de0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52509669 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 3, 2024
Summary: The current scrollViewExamples does not trigger the OnScrollToTop event. This change for Paper adds that and refactors the codebase to isolate that example. ## Changelog: [Internal] - Improve RNTester ScrollView example adding OnScrollView event. Reviewed By: sammy-SC Differential Revision: D52509669
|
This pull request was successfully merged by @cipolleschi in 6cd1aaf. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The current scrollViewExamples does not trigger the OnScrollToTop event.
This change for Paper adds that and refactors the codebase to isolate that example.
Changelog:
[Internal] - Improve RNTester ScrollView example adding OnScrollView event.
Reviewed By: sammy-SC
Differential Revision: D52509669