UIManagerJSInterface: Make reactTags non-nullable#42208
Closed
RSNara wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52627087 |
Base commit: d16531e |
RSNara
force-pushed
the
export-D52627087
branch
from
f604a57 to
bbd5b98
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52627087 |
RSNara
force-pushed
the
export-D52627087
branch
from
bbd5b98 to
55b1b01
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52627087 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52627087 |
RSNara
force-pushed
the
export-D52627087
branch
from
55b1b01 to
5f14f87
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52627087 |
RSNara
force-pushed
the
export-D52627087
branch
from
5f14f87 to
a4b9c2b
Compare
RSNara
force-pushed
the
export-D52627087
branch
from
a4b9c2b to
c24fb19
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52627087 |
RSNara
force-pushed
the
export-D52627087
branch
from
1e226cb to
f90949a
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 21, 2024
Summary: Pull Request resolved: facebook#42208 I went through the [android](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java?fbclid=IwAR29Xk1KiGsxg7O2Fc7F2k4uKFmqqAbcMtsEEdaBalcGjJK7xuyYDo6X1Z8) and [ios](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Modules/RCTUIManager.m?fbclid=IwAR2axOTNVuvGbnGw0_1wlnRhftx4W6K-ptTm_DtQ-eSOLFtnrYwzbjPyeYA) implementations of UIManagerModule. It turns out, the reactTag is always nonnull in all methods! This diff updates UIManagerJSInterface accordingly. Changelog: [General][Changed] - UIManagerModule: Make reactTags required Differential Revision: D52627087 Reviewed By: sammy-SC fbshipit-source-id: de331f8c13c324d3c267bec0b449ea0944a697f9
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 22, 2024
…#42208) Summary: I went through the [android](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java?fbclid=IwAR29Xk1KiGsxg7O2Fc7F2k4uKFmqqAbcMtsEEdaBalcGjJK7xuyYDo6X1Z8) and [ios](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Modules/RCTUIManager.m?fbclid=IwAR2axOTNVuvGbnGw0_1wlnRhftx4W6K-ptTm_DtQ-eSOLFtnrYwzbjPyeYA) implementations of UIManagerModule. It turns out, the reactTag is always nonnull in all methods! This diff updates UIManagerJSInterface accordingly. Changelog: [General][Changed] - UIManagerModule: Make reactTags required Reviewed By: sammy-SC Differential Revision: D52627087
RSNara
force-pushed
the
export-D52627087
branch
from
f90949a to
fec0a12
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52627087 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 22, 2024
Summary: Pull Request resolved: facebook#42208 I went through the [android](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java?fbclid=IwAR29Xk1KiGsxg7O2Fc7F2k4uKFmqqAbcMtsEEdaBalcGjJK7xuyYDo6X1Z8) and [ios](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Modules/RCTUIManager.m?fbclid=IwAR2axOTNVuvGbnGw0_1wlnRhftx4W6K-ptTm_DtQ-eSOLFtnrYwzbjPyeYA) implementations of UIManagerModule. It turns out, the reactTag is always nonnull in all methods! This diff updates UIManagerJSInterface accordingly. Changelog: [General][Changed] - UIManagerModule: Make reactTags required Differential Revision: D52627087 Reviewed By: sammy-SC fbshipit-source-id: fa3344b13d429849d629e3816fa097368edb2375
Summary: This API was used by the old architecture to lazily register/load components: 1. Load a ViewManager's class from the disk 2. Register the ViewManager's class with React Native See: [RCTUIManager lazilyLoadView](https://github.com/facebook/react-native/blob/822bf52c29729d25b2bfb31655cf773609a9283d/packages/react-native/React/Modules/RCTUIManager.m#L1546-L1591) The new architecture **does not** support lazy loading of **legacy** modules/components. Therefore, let's leave this API unimplemented until we decide to implement lazy loading of legacy stuff in new architecture. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D52677515
Summary: I went through the [android](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java?fbclid=IwAR29Xk1KiGsxg7O2Fc7F2k4uKFmqqAbcMtsEEdaBalcGjJK7xuyYDo6X1Z8) and [ios](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Modules/RCTUIManager.m?fbclid=IwAR2axOTNVuvGbnGw0_1wlnRhftx4W6K-ptTm_DtQ-eSOLFtnrYwzbjPyeYA) implementations of UIManagerModule. It turns out, the reactTag is always nonnull in all methods! This diff updates UIManagerJSInterface accordingly. Changelog: [General][Changed] - UIManagerModule: Make reactTags required Reviewed By: sammy-SC Differential Revision: D52627087
RSNara
force-pushed
the
export-D52627087
branch
from
fec0a12 to
c38d40a
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Jan 22, 2024
…#42208) Summary: I went through the [android](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java?fbclid=IwAR29Xk1KiGsxg7O2Fc7F2k4uKFmqqAbcMtsEEdaBalcGjJK7xuyYDo6X1Z8) and [ios](https://github.com/facebook/react-native/blob/main/packages/react-native/React/Modules/RCTUIManager.m?fbclid=IwAR2axOTNVuvGbnGw0_1wlnRhftx4W6K-ptTm_DtQ-eSOLFtnrYwzbjPyeYA) implementations of UIManagerModule. It turns out, the reactTag is always nonnull in all methods! This diff updates UIManagerJSInterface accordingly. Changelog: [General][Changed] - UIManagerModule: Make reactTags required Reviewed By: sammy-SC Differential Revision: D52627087
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52627087 |
Contributor
|
This pull request has been merged in fafd00a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I went through the android and ios implementations of UIManagerModule. It turns out, the reactTag is always nonnull in all methods!
This diff updates UIManagerJSInterface accordingly.
Changelog: [Changed][General] - UIManagerModule: Make reactTags required
Differential Revision: D52627087