Fix AndroidManifest.xml for RN-Tester in OSS#42248
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52694108 |
Base commit: f30acc6 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52694108 |
cortinico
force-pushed
the
export-D52694108
branch
from
72af026 to
fc892ea
Compare
Summary: Pull Request resolved: facebook#42248 I'm duplicating the AndroidManifest.xml file internally/externally as Gradle is really unhappy with it (and gets really noisy): - It contains a package declaration which should be removed - It contains a uses-sdk which should also be removed Changelog: [Internal] [Changed] - Fix AndroidManifest.xml for RN-Tester in OSS Reviewed By: christophpurrer Differential Revision: D52694108 fbshipit-source-id: 5363b293d8c1530ccfeac1a5c17a45bd384df51d
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52694108 |
cortinico
force-pushed
the
export-D52694108
branch
from
fc892ea to
37aa8a7
Compare
Contributor
|
This pull request has been merged in 668a011. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I'm duplicating the AndroidManifest.xml file internally/externally as Gradle is really unhappy with it (and gets really noisy):
Changelog:
[Internal] [Changed] - Fix AndroidManifest.xml for RN-Tester in OSS
Differential Revision: D52694108