Distinguish between modern/legacy targets, conditionally disable hacks#42303
Closed
motiz88 wants to merge 1 commit into
Closed
Distinguish between modern/legacy targets, conditionally disable hacks#42303motiz88 wants to merge 1 commit into
motiz88 wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50967795 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50967795 |
motiz88
force-pushed
the
export-D50967795
branch
from
dbff311 to
b2cb526
Compare
Base commit: 8474e23 |
motiz88
force-pushed
the
export-D50967795
branch
from
b2cb526 to
b918f7f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50967795 |
facebook#42303) Summary: Changelog: [Internal] Adds a coarse-grained mechanism to `inspector-proxy` for distinguishing between legacy and modern debug targets. The guiding principles are: 1. `inspector-proxy` does not interfere in the CDP message stream between the debugger frontend and a modern target, or in the lifecycle of a target. 2. Legacy runtimes (current React Native, React Native Desktop, etc) that rely on `inspector-proxy`'s existing invasive semantics must continue to work seamlessly for now. We'll decide on the right time to deprecate/remove this legacy code in the future. NOTE: This is an experimental addition to the proxy protocol that may be replaced at any time. Reviewed By: hoxyq Differential Revision: D50967795
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Jan 18, 2024
…sable hacks (facebook#42303) Summary: Changelog: [Internal] Adds a coarse-grained mechanism to `inspector-proxy` for distinguishing between legacy and modern debug targets. The guiding principles are: 1. `inspector-proxy` does not interfere in the CDP message stream between the debugger frontend and a modern target, or in the lifecycle of a target. 2. Legacy runtimes (current React Native, React Native Desktop, etc) that rely on `inspector-proxy`'s existing invasive semantics must continue to work seamlessly for now. We'll decide on the right time to deprecate/remove this legacy code in the future. NOTE: This is an experimental addition to the proxy protocol that may be replaced at any time. Reviewed By: hoxyq Differential Revision: D50967795
motiz88
force-pushed
the
export-D50967795
branch
from
b918f7f to
11a1fb3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50967795 |
Contributor
|
This pull request has been merged in 716c728. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Adds a coarse-grained mechanism to
inspector-proxyfor distinguishing between legacy and modern debug targets. The guiding principles are:inspector-proxydoes not interfere in the CDP message stream between the debugger frontend and a modern target, or in the lifecycle of a target.inspector-proxy's existing invasive semantics must continue to work seamlessly for now. We'll decide on the right time to deprecate/remove this legacy code in the future.NOTE: This is an experimental addition to the proxy protocol that may be replaced at any time.
Differential Revision: D50967795