Fix ImagePicker crashed when it works with keyboard#4231
Fix ImagePicker crashed when it works with keyboard#4231cizhaoyang wants to merge 1 commit intofacebook:masterfrom
Conversation
|
By analyzing the blame information on this pull request, we identified @dvcrn, @nicklockwood and @yusefnapora to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Those methods should already be called on the main thread due to the Can you please provide a sample project demonstrating the crash so I can investigate further? |
If the SafariView is triggered while the keyboard is active, the following exception is thrown: `[UIKeyboardTaskQueue waitUntilAllTasksAreFinished] may only be called from the main thread.` This is similar to facebook/react-native#4231, which was resolved by cizhaoyang/react-native@6dd171b. This pull request forces the SafariViewManager to run on the main thread. See https://facebook.github.io/react-native/docs/native-modules-ios.html#threading for more details.
|
Hey @cizhaoyang! Thanks for making the pull request, but we are closing it due to inactivity (115 days with no activity) to make sure all pull requests are either being worked on or closed. If you want to get your proposed changes merged, please rebase your branch with master and send a new pull request :) Based on the comment above:
|
4 participants
I want to pop-up the image picker when I press a button. But if the keyboard is active and displayed on the screen, I will get a
crash error. Move present image picker view code to main thread queue is able to fix the problem.