Remove linting step from dangerfile#42332
Closed
motiz88 wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52834693 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ packages/react-native-bots/dangerfile.js line 106 – 'handleStatuses' is defined but never used. (no-unused-vars)
motiz88
force-pushed
the
export-D52834693
branch
from
71b011d to
2267ccb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52834693 |
motiz88
force-pushed
the
export-D52834693
branch
from
2267ccb to
bdc831d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52834693 |
Base commit: 6c8dfc8 |
motiz88
force-pushed
the
export-D52834693
branch
from
bdc831d to
e1c8c4d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52834693 |
Summary: Changelog: [Internal] TSIA - the Danger ESLint plugin we use is outdated and there have been issues with its reliability. We already have [linting jobs on CircleCI](https://github.com/facebook/react-native/blob/6c8dfc89566d27c36f9ca3828bcf3a63dfcb6942/.circleci/configurations/jobs.yml#L5-L74) that overlap with this functionality. Reviewed By: cortinico Differential Revision: D52834693
motiz88
force-pushed
the
export-D52834693
branch
from
e1c8c4d to
992907a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52834693 |
Contributor
|
This pull request has been merged in 8e70acc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D52834693
Pull Request resolved: #42332
Changelog: [Internal]
TSIA - the Danger ESLint plugin we use is outdated and there have been issues with its reliability. We already have linting jobs on CircleCI that overlap with this functionality.