[RN] Add support for src directory in react-native#42385
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
59d1144 to
970df79
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
Base commit: a758694 |
rubennorte
force-pushed
the
export-D52875999
branch
from
970df79 to
7d2ee3b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
7d2ee3b to
8ccb1ff
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
8ccb1ff to
6fadde5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
6fadde5 to
87b64c9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
87b64c9 to
d81eb38
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
d81eb38 to
f075eac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
f075eac to
f54b2b9
Compare
rubennorte
force-pushed
the
export-D52875999
branch
from
ab5cd57 to
d105c38
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
d105c38 to
0253b2c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
0253b2c to
a33abd0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
force-pushed
the
export-D52875999
branch
from
a33abd0 to
fc6590c
Compare
rubennorte
changed the title
rubennorte
force-pushed
the
export-D52875999
branch
from
fc6590c to
404663e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
Summary: This adds support for having JS files in a `src` directory within the `react-native` package. The plan is to have 2 subdirectories there: * `react-native/src/private` for private modules, with any nested directories (e.g.: `react-native/src/private/dom/nodes/ReadOnlyNode.js`). * `react-native/src/public` for public modules, without nested directories. The plan is that the individual modules created in this directory will be public through the index module or directly via something like `react-native/View` (mapped to `react-native/src/public/View`, or a `dist` directory in the published npm package—details TBD). The enforcement of private modules being inaccessible from outside the `react-native` package will be added soon by huntie. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875999
rubennorte
force-pushed
the
export-D52875999
branch
from
404663e to
dd31f54
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52875999 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 22, 2024
Summary: Pull Request resolved: facebook#42385 This adds support for having JS files in a `src` directory within the `react-native` package. The plan is to have 2 subdirectories there: * `react-native/src/private` for private modules, with any nested directories (e.g.: `react-native/src/private/dom/nodes/ReadOnlyNode.js`). * `react-native/src/public` for public modules, without nested directories. The plan is that the individual modules created in this directory will be public through the index module or directly via something like `react-native/View` (mapped to `react-native/src/public/View`, or a `dist` directory in the published npm package—details TBD). The enforcement of private modules being inaccessible from outside the `react-native` package will be added soon by huntie. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875999 fbshipit-source-id: 425126644258987f58e249b67a7da0c625e48bad
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 22, 2024
Summary: Pull Request resolved: facebook#42385 This adds support for having JS files in a `src` directory within the `react-native` package. The plan is to have 2 subdirectories there: * `react-native/src/private` for private modules, with any nested directories (e.g.: `react-native/src/private/dom/nodes/ReadOnlyNode.js`). * `react-native/src/public` for public modules, without nested directories. The plan is that the individual modules created in this directory will be public through the index module or directly via something like `react-native/View` (mapped to `react-native/src/public/View`, or a `dist` directory in the published npm package—details TBD). The enforcement of private modules being inaccessible from outside the `react-native` package will be added soon by huntie. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875999 fbshipit-source-id: 58ee306f4fafd57ea73e9fd5c5401cce73013a26
Contributor
|
This pull request has been merged in 3c2c486. |
Contributor
|
This pull request has been reverted by c92f7e5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This adds support for having JS files in a directory within the package. The plan is to have 2 subdirectories there:
The enforcement of private modules being inaccessible from outside the package will be added soon by huntie.
Changelog: [internal]
Differential Revision: D52875999