RNTester: add legacy style event to MyNativeViewNativeComponent#42809
Closed
dmytrorykun wants to merge 1 commit into
Closed
RNTester: add legacy style event to MyNativeViewNativeComponent#42809dmytrorykun wants to merge 1 commit into
dmytrorykun wants to merge 1 commit into
Conversation
Summary: This diff adds a legacy style event to `MyNativeViewNativeComponent`. This is a way of defining events where you specify additional string type parameter in the EventHandler in the spec. This additional type parameter is an overridden top level event name, that can be completely unrelated to the event handler name. In this example it is `onLegacyStyleEvent` and `alternativeLegacyName`. More context here D16042065. Changelog: [Internal] Differential Revision: D53310318
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53310318 |
Base commit: 184b295 |
Contributor
|
This pull request has been merged in 4d07aae. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds a legacy style event to
MyNativeViewNativeComponent.This is a way of defining events where you specify additional string type parameter in the EventHandler in the spec. This additional type parameter is an overridden top level event name, that can be completely unrelated to the event handler name.
In this example it is
onLegacyStyleEventandalternativeLegacyName.More context here D16042065.
Changelog: [Internal]
Differential Revision: D53310318