Convert unannotated variable declaration with cast init to annotated variable declaration in xplat/js#42880
Closed
gkz wants to merge 1 commit into
Closed
Convert unannotated variable declaration with cast init to annotated variable declaration in xplat/js#42880gkz wants to merge 1 commit into
gkz wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53392999 |
…variable declaration in xplat/js (facebook#42880) Summary: Convert `const x = (a: T)` into `const x: T = a`. These are equivalent in Flow, and helps reduce the amount of colon-casts. ``` js1 flow-runner codemod flow/castToAnnotatedVariable --target colon xplat/js ``` Changelog: [Internal] drop-conflicts Differential Revision: D53392999
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53392999 |
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Feb 6, 2024
…variable declaration in xplat/js Summary: X-link: facebook/react-native#42880 Convert `const x = (a: T)` into `const x: T = a`. These are equivalent in Flow, and helps reduce the amount of colon-casts. ``` js1 flow-runner codemod flow/castToAnnotatedVariable --target colon xplat/js ``` Changelog: [Internal] drop-conflicts Reviewed By: SamChou19815 Differential Revision: D53392999 fbshipit-source-id: 3b4602618d6990e8642b423edaeb4e89b01a199a
Contributor
|
This pull request has been merged in 608029a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Convert
const x = (a: T)intoconst x: T = a. These are equivalent in Flow, and helps reduce the amount of colon-casts.Changelog: [Internal]
drop-conflicts
Differential Revision: D53392999