Fix order of Metro hotkey console messages#42896
Closed
EdmondChuiHW wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53479732 |
Summary: Changelog: [General][Fixed] Fix order of Metro hotkey console messages # Existing Key handler is printing messages to the console _after_ it has been processed, this causes error messages to appear before the `info` message. # In this PR The `info` messages are logged before the event is processed. Reviewed By: GijsWeterings Differential Revision: D53479732
EdmondChuiHW
force-pushed
the
export-D53479732
branch
from
aedf533 to
4c4eaaf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53479732 |
Contributor
|
This pull request has been merged in 635732a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General][Fixed] Fix order of Metro hotkey console messages
Existing
Key handler is printing messages to the console after it has been processed, this causes error messages to appear before the
infomessage.In this PR
The
infomessages are logged before the event is processed.Differential Revision: D53479732