Add support for bumping packages on main after release cut#42958
Closed
lunaleaps wants to merge 2 commits into
Closed
Add support for bumping packages on main after release cut#42958lunaleaps wants to merge 2 commits into
lunaleaps wants to merge 2 commits into
Conversation
Summary: Changelog: [Internal] - Update publish-npm to use `set-version` for nightly builds Now that `set-version` basically does what `set-rn-version` does, this diff uses this logic for nightlies only (as dry-run/pre-alpha variants are non-functional right now) This does not change the flow of build-type `'release'` -- that will still use `set-rn-version` via CircleCI ([job](https://fburl.com/code/6xo3ijwg), [script](https://fburl.com/code/bo8np0tb)) We will eventually replace that too but that will be later. This allows us to delete `get-and-update-packages.js` which was a helper written specifically for updating monorepo packages for nightlies. The purpose of this is to eventually conform all version updates to use `set-version` in all types of releases (nightlies, stable) Reviewed By: cipolleschi Differential Revision: D53487874
Summary: Changelog: [Internal] - Add support to `set-version` that we can bump the monorepo packages on main This should be used after we cut a release branch. The release crew should then run `yarn set-version 0.next.0-main --skip-react-native-version` This makes sure we don't update `react-native` on main branch and keep it at 1000.0.0 This essentially replaces: `yarn bump-all-updated-packages --release-branch-cutoff` in this step: https://reactnative.dev/contributing/release-branch-cut-and-rc0#12-bump-minor-version-of-all-monorepo-packages-in-main The reason for this change is to consolidate all the places where we update the version to one place, set-version. Currently we do this in many fragmented places * bump-all-updated-packages * set-rn-version * get-and-update-packages (deleted in the prev diff) In the future, I want to get rid of `skip-react-native-version` but we'll need to remove the `1000.0.0` nomenclature. This unblocks us to just use this script for now. Differential Revision: D53648688
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53648688 |
Contributor
|
This pull request has been merged in 2090fe5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal] - Add support to
set-versionthat we can bump the monorepo packages on mainThis should be used after we cut a release branch. The release crew should then run
yarn set-version 0.next.0-main --skip-react-native-versionThis makes sure we don't update
react-nativeon main branch and keep it at 1000.0.0This essentially replaces:
yarn bump-all-updated-packages --release-branch-cutoffin this step: https://reactnative.dev/contributing/release-branch-cut-and-rc0#12-bump-minor-version-of-all-monorepo-packages-in-main
The reason for this change is to consolidate all the places where we update the version to one place, set-version.
Currently we do this in many fragmented places
In the future, I want to get rid of
skip-react-native-versionbut we'll need to remove the1000.0.0nomenclature. This unblocks us to just use this script for now.Differential Revision: D53648688