Enable the native module for feature flags by default for iOS apps in OSS#43159
Closed
rubennorte wants to merge 1 commit into
Closed
Enable the native module for feature flags by default for iOS apps in OSS#43159rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54082349 |
rubennorte
force-pushed
the
export-D54082349
branch
from
c26be00 to
13e83d9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54082349 |
rubennorte
force-pushed
the
export-D54082349
branch
from
13e83d9 to
18ec663
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54082349 |
Base commit: 073ca1a |
rubennorte
force-pushed
the
export-D54082349
branch
from
18ec663 to
c9ad015
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54082349 |
rubennorte
changed the title
rubennorte
force-pushed
the
export-D54082349
branch
from
c9ad015 to
a87eaa6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54082349 |
rubennorte
force-pushed
the
export-D54082349
branch
from
a87eaa6 to
477c40a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54082349 |
… OSS (facebook#43159) Summary: Changelog: [internal] This modifies the default `RCTAppDelegate` for iOS apps in OSS to provide an implementation for the C++ native module for feature flags. In a following diff I'll replace the `React-featureflagsnativemodule.podspec` file with one that includes all built-in C++ native modules. Reviewed By: RSNara Differential Revision: D54082349
rubennorte
force-pushed
the
export-D54082349
branch
from
477c40a to
577a960
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54082349 |
Contributor
|
This pull request has been merged in 0eac418. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This modifies the default
RCTAppDelegatefor iOS apps in OSS to provide an implementation for the C++ native module for feature flags.In a following diff I'll replace the
React-featureflagsnativemodule.podspecfile with one that includes all built-in C++ native modules.Differential Revision: D54082349