Manual: Codemod initializeWithInstance() callers to BridgeReactContext#43627
Closed
RSNara wants to merge 2 commits intofacebook:mainfrom
Closed
Manual: Codemod initializeWithInstance() callers to BridgeReactContext#43627RSNara wants to merge 2 commits intofacebook:mainfrom
RSNara wants to merge 2 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218593 |
RSNara
force-pushed
the
export-D55218593
branch
from
062d979 to
4ff7215
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218593 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218593 |
RSNara
force-pushed
the
export-D55218593
branch
from
4ff7215 to
a7011ed
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218593 |
RSNara
force-pushed
the
export-D55218593
branch
2 times, most recently
from
c3a2f4f to
c72c59c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218593 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218593 |
RSNara
force-pushed
the
export-D55218593
branch
from
c72c59c to
5456ae7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218593 |
RSNara
force-pushed
the
export-D55218593
branch
from
5456ae7 to
8536784
Compare
Summary: Eventually, we will move all bridge methods to BridgeReactContext. Long-term, ReactApplicationContext and ReactContext will become abstract. And these two contexts will only contain methods common to both modes. Changelog: [Android][Added] Introduce BridgeReactContext Differential Revision: https://internalfb.com/D55218592
facebook#43627) Summary: Pull Request resolved: facebook#43627 Eventaully, ReactApplicationContext.initailizeWithInstance() will be moved to BridgeReactContext. Doing the migration up-front to remove noise from the eventual diff. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D55218593
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218593 |
RSNara
force-pushed
the
export-D55218593
branch
from
8536784 to
46b0d51
Compare
Contributor
|
This pull request has been merged in a984169. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Eventaully, ReactApplicationContext.initailizeWithInstance() will be moved to BridgeReactContext.
Doing the migration up-front to remove noise from the eventual diff.
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D55218593