Remove unnecessary wrapper from Performance/PerformanceObserver examples screen in RNTester#43706
Closed
rubennorte wants to merge 6 commits into
Closed
Remove unnecessary wrapper from Performance/PerformanceObserver examples screen in RNTester#43706rubennorte wants to merge 6 commits into
rubennorte wants to merge 6 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55489933 |
…cebook#43705) Summary: Changelog: [internal] Reviewed By: rshest Differential Revision: D55477744
…RNTester (facebook#43704) Summary: Changelog: [internal] Adding examples of the rest of APIs in `Performance`/`PerformanceObserver` starting with marks and measures. Reviewed By: rshest Differential Revision: D55477746
…ame (facebook#43703) Summary: Changelog: [internal] (internal because this API isn't available in OSS yet) I found a bug in the current implementation of `performance.measure` where the API would use the first `mark` reported under a specific name instead of the last one (found it in the new example in RNTester in D55477746 that re-logs the marks every time we click on a button). The root cause for this problem is that we were using `insert` from `std::unordered_set` to update the value, but `insert` doesn't modify the value if it's already present. This fixes the issue by doing a lookup and removing the value prior to inserting it. Differential Revision: D55477743
…er (facebook#43702) Summary: Changelog: [internal] Just a minor refactor to use C++20 designated initializers in `PerformanceEntryReporter` and its tests, while removing unnecessary initialization for optional fields. Reviewed By: rshest Differential Revision: D55477745
…erver (facebook#43701) Summary: Changelog: [internal] We were defining an `UNDEFINED` type of entry that should never happen in practice and we were using unnecessarily to signal "no type" where an optional type would be more suitable. Most importantly, **we were incorrectly allocating a buffer for entries of this type**. This removes that type and the unnecessary buffer. Reviewed By: rshest Differential Revision: D55478890
…les screen in RNTester (facebook#43706) Summary: Changelog: [internal] Just a small improvement of the UI for the Performance API examples in RNTester. Differential Revision: D55489933
rubennorte
force-pushed
the
export-D55489933
branch
from
a119066 to
f39d6f6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55489933 |
Base commit: ad93680 |
Contributor
|
This pull request has been merged in 2f1643d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Just a small improvement of the UI for the Performance API examples in RNTester.
Differential Revision: D55489933