Allow sigma blur without filter prop#43721
Closed
NickGerleman wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55563775 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55563775 |
NickGerleman
force-pushed
the
export-D55563775
branch
from
ee2a2aa to
d07a7a2
Compare
Differential Revision: D55565035
Summary: Pull Request resolved: facebook#43721 Makes some changes to `FilterHelper` to expose RenderEffects for filters publicly to other classes in the module. We use this in box-shadow, in order to reuse logic for sigma accepting blur filters. Also fixes a crash related to the conversions back and forward between sigma and radius, where small values would cause a crash. Changelog: [inernal] Reviewed By: joevilches Differential Revision: D55563775
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55563775 |
NickGerleman
force-pushed
the
export-D55563775
branch
from
d07a7a2 to
910dfe5
Compare
Contributor
|
This pull request has been merged in efc5ddd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Makes some changes to
FilterHelperto expose RenderEffects for filters publicly to other classes in the module. We use this in box-shadow, in order to reuse logic for sigma accepting blur filters.Also fixes a crash related to the conversions back and forward between sigma and radius, where small values would cause a crash.
Changelog: [inernal]
Differential Revision: D55563775