Enable Kotlin warnings as errors in rn_android_library#43755
Closed
NickGerleman wants to merge 2 commits into
Closed
Enable Kotlin warnings as errors in rn_android_library#43755NickGerleman wants to merge 2 commits into
NickGerleman wants to merge 2 commits into
Conversation
Summary: Moves off of deprecated `DisplayMetrics.scaledDensity` API to builtin font scaling API, while still clamping to max multiplier using previous logic. Changelog: [Internal] Differential Revision: D55623674
Summary: This is another place where the OSS build went ahead of the internal source of truth, which has caused build breaks more than once. This enables warnings as errors in `rn_android_library` for consistency. This is used for a couple libraries outside of ReactAndroid that might need fixup/suppression. Changelog: [Internal] Differential Revision: D55623682
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55623682 |
Base commit: 2205880 |
Contributor
|
This pull request has been merged in 15a965f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is another place where the OSS build went ahead of the internal source of truth, which has caused build breaks more than once.
This enables warnings as errors in
rn_android_libraryfor consistency. This is used for a couple libraries outside of ReactAndroid that might need fixup/suppression.Changelog: [Internal]
Differential Revision: D55623682