Skip to content

feat: Trigger Java GC on reload #43813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrousavy wants to merge 5 commits into from
Closed

feat: Trigger Java GC on reload #43813

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df3ba5f
feat: Trigger Java GC on reload
mrousavy Apr 3, 2024
d7579de
fix: Also do for bridgeless
mrousavy Apr 3, 2024
9ee0da2
fix: Trigger `gc()` _after_ reload, not _before_
mrousavy Apr 3, 2024
d3b7049
chore: Move GC call to `ReactInstanceManager::recreateReactContextInB…
mrousavy Apr 3, 2024
417a2b2
fix: Move into `onReactInstanceDestroyed(..)`
mrousavy Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ative/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,13 @@ public void onReactInstanceDestroyed(ReactContext reactContext) {
// for this manager
resetCurrentContext(null);
}

// If some JNI types (e.g. jni::HybridClass) are used in JSI (e.g. jsi::HostObject), they might
// not be immediately deleted on an app refresh as both Java and JavaScript are
// garbage-collected languages and the memory might float around for a while.
// For C++ developers, this will be hard to debug as destructors might be called at a later point,
// so in this case we trigger a Java GC to maybe eagerly collect such objects when the app reloads.
System.gc();
}

@Override
Expand Down