Fix problems in PerformanceObserver notifications#43847
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646390 |
rubennorte
force-pushed
the
export-D55646390
branch
from
9c92e49 to
74ea8bc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646390 |
rubennorte
force-pushed
the
export-D55646390
branch
from
74ea8bc to
f3e835c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646390 |
rubennorte
force-pushed
the
export-D55646390
branch
from
f3e835c to
c4b6a31
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646390 |
rubennorte
force-pushed
the
export-D55646390
branch
from
c4b6a31 to
2b0b480
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646390 |
rubennorte
force-pushed
the
export-D55646390
branch
from
2b0b480 to
33b6577
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646390 |
Summary: Changelog: [internal] (This is an internal change because the API hasn't been released in OSS yet) This fixes 2 problems in how we dispatch `PerformanceObserver` notifications: 1. If an observer callback throws an error, the remaining observers don't receive notifications. 2. We're notifying observers with an empty list of events when they don't match the filters. Reviewed By: javache Differential Revision: D55646390
rubennorte
force-pushed
the
export-D55646390
branch
from
33b6577 to
e0b4a1d
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 9, 2024
…#43847) Summary: Changelog: [internal] (This is an internal change because the API hasn't been released in OSS yet) This fixes 2 problems in how we dispatch `PerformanceObserver` notifications: 1. If an observer callback throws an error, the remaining observers don't receive notifications. 2. We're notifying observers with an empty list of events when they don't match the filters. Reviewed By: javache Differential Revision: D55646390
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646390 |
Contributor
|
This pull request has been merged in af27d29. |
|
This pull request was successfully merged by @rubennorte in af27d29. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
(This is an internal change because the API hasn't been released in OSS yet)
This fixes 2 problems in how we dispatch
PerformanceObservernotifications:Differential Revision: D55646390