Remove boost version#43920
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55801708 |
Base commit: b52c7aa |
Summary: React native is shipped as a whole, so it makes no sense for individual pods to specify which version of boost they support. With this change we let the `react_native_pods` and the `boost.podspec` file to decide which version of boost is supported and all the other podspecs will follow. ## Changelog: [Internal] - Remove explicit boost version from other podspecs Reviewed By: NickGerleman Differential Revision: D55801708
cipolleschi
force-pushed
the
export-D55801708
branch
from
1f15f99 to
9ff69eb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55801708 |
|
This pull request was successfully merged by @cipolleschi in c0ed2f4. When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in c0ed2f4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
React native is shipped as a whole, so it makes no sense for individual pods to specify which version of boost they support.
With this change we let the
react_native_podsand theboost.podspecfile to decide which version of boost is supported and all the other podspecs will follow.Changelog:
[Internal] - Remove explicit boost version from other podspecs
Differential Revision: D55801708