Fix broken HermesExecutor compilation#43932
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Summary: Converting to Kotlin the `RuntimeConfig` class caused the project to stop compiling. Changelog: [Internal] [Changed] - Fix broken HermesExecutor compilation Differential Revision: D55805572
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55805572 |
cortinico
force-pushed
the
export-D55805572
branch
from
063c4ff to
60170ee
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55805572 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Converting to Kotlin the `RuntimeConfig` class caused the project to stop compiling. Changelog: [Internal] [Changed] - Fix broken HermesExecutor compilation Differential Revision: D55805572
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 5, 2024
Summary: Converting to Kotlin the `RuntimeConfig` class caused the project to stop compiling. Changelog: [Internal] [Changed] - Fix broken HermesExecutor compilation Reviewed By: tdn120 Differential Revision: D55805572
Base commit: 03c75c2 |
Contributor
|
This pull request has been merged in f14746f. |
|
This pull request was successfully merged by @cortinico in f14746f. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Converting to Kotlin the
RuntimeConfigclass caused the project to stop compiling.Changelog:
[Internal] [Changed] - Fix broken HermesExecutor compilation
Differential Revision: D55805572