Noop: ReactInstance: Add todo above getRuntimeScheduler()#43952

Closed

RSNara wants to merge 1 commit intofacebook:mainfrom

RSNara:export-D55547899

Contributor

RSNara commented Apr 7, 2024

Summary:
getRuntimeScheduler() allows things to schedule work on the js thread by bypassing main bundle buffering.

This is unsafe: almost everything should be using the buffered runtime executor, unless it sets up bindings used in the main bundle.

I filed a task for the investigation to see if there's any problems. And added it to the code in this diff.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547899

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899

facebook-github-bot added the fb-exported label

RSNara force-pushed the export-D55547899 branch from 6a313bf to b8b0621 Compare

April 7, 2024 18:02

analysis-bot commented Apr 7, 2024 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	19,217,868	-9
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,594,634	+3
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: f77d028
Branch: main

RSNara force-pushed the export-D55547899 branch from b8b0621 to 44cfe77 Compare

April 7, 2024 19:03

Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899

RSNara force-pushed the export-D55547899 branch from 44cfe77 to 480eb6e Compare

April 7, 2024 19:19

Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899

RSNara force-pushed the export-D55547899 branch from 480eb6e to d645156 Compare

April 7, 2024 19:39

Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899

RSNara force-pushed the export-D55547899 branch from d645156 to f784148 Compare

April 7, 2024 19:56

Contributor

facebook-github-bot commented Apr 7, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899

RSNara force-pushed the export-D55547899 branch from f196275 to cfdd77f Compare

April 8, 2024 01:14

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899

RSNara force-pushed the export-D55547899 branch from cfdd77f to 7e1c435 Compare

April 8, 2024 17:55

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899

RSNara force-pushed the export-D55547899 branch from 7e1c435 to b946b4f Compare

April 8, 2024 18:02

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899


          Noop: ReactInstance: Add todo above getRuntimeScheduler()

55ef537

Summary:
getRuntimeScheduler() allows things to schedule work on the js thread by bypassing main bundle buffering.

This is unsafe: almost everything should be using the buffered runtime executor, unless it sets up bindings used in the main bundle.

I filed a task for the investigation to see if there's any problems. And added it to the code in this diff.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547899

RSNara force-pushed the export-D55547899 branch from b946b4f to 55ef537 Compare

April 8, 2024 19:20

Contributor

facebook-github-bot commented Apr 8, 2024

This pull request was exported from Phabricator. Differential Revision: D55547899

RSNara added a commit to RSNara/react-native that referenced this pull request


          [skip ci] Noop: ReactInstance: Add todo above getRuntimeScheduler() (f…

694f9d7

…acebook#43952)

Summary:

getRuntimeScheduler() allows things to schedule work on the js thread by bypassing main bundle buffering.

This is unsafe: almost everything should be using the buffered runtime executor, unless it sets up bindings used in the main bundle.

I filed a task for the investigation to see if there's any problems. And added it to the code in this diff.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547899

RSNara added a commit to RSNara/react-native that referenced this pull request


          [skip ci] Noop: ReactInstance: Add todo above getRuntimeScheduler() (f…

22bc85f

…acebook#43952)

Summary:

getRuntimeScheduler() allows things to schedule work on the js thread by bypassing main bundle buffering.

This is unsafe: almost everything should be using the buffered runtime executor, unless it sets up bindings used in the main bundle.

I filed a task for the investigation to see if there's any problems. And added it to the code in this diff.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D55547899

facebook-github-bot closed this in

9ad7138

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Apr 9, 2024

This pull request has been merged in 9ad7138.

github-actions Bot commented Apr 9, 2024

This pull request was successfully merged by @RSNara in 9ad7138.

^{When will my fix make it into a release? | How to file a pick request?}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner